[ 
https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036202#comment-13036202
 ] 

Daryn Sharp commented on HADOOP-6605:
-------------------------------------

Love it.  Comments:

SunOS - why not jdk1.6.* to get latest patch version, or jdk*.*?  Using the 
last item in the glob expansion or search in reverse order should generally get 
the latest version.

Linux - Same as SunOS.  Also, why aren't /usr/java/default and 
/usr/lib/jvm/default-java checked first?

Overall, maybe globs aren't a great idea since it may lead to a lot more paths 
being added which I think is Eli's concern.  Would it make more sense to only 
support using the "standard" mechanisms of an OS if that OS provides one?  In 
which case the functionality is to make hadoop a good citizen of that OS, and 
not to make pseudo-intelligent guesses?

> Add JAVA_HOME detection to hadoop-config
> ----------------------------------------
>
>                 Key: HADOOP-6605
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6605
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Chad Metcalf
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6605.patch, hadoop-6605-1.patch, 
> hadoop-6605-2.patch
>
>
> The commands that source hadoop-config.sh currently bail with an error if 
> JAVA_HOME is not set. Let's detect JAVA_HOME (from a list of locations on 
> various OS types) if JAVA_HOME is not already set by hadoop-env.sh or the 
> environment. This way users don't have to manually configure it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to