[ 
https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036480#comment-13036480
 ] 

Eli Collins commented on HADOOP-6605:
-------------------------------------

bq. FYI: I'm not removing my -1 as long as this remains in the main hadoop bin 
code path.

Allen - what is your technical objection? There is not a performance impact to 
hadoop-config.sh, and even if there were, hadoop-config.sh is not a measurable 
part of hadoop command execution.

{noformat}
common1 (trunk)$ export JAVA_HOME=/home/eli/toolchain/jdk1.6.0_24-x64
common1 (trunk)$ time for i in {1..10}; do . bin/hadoop-config.sh ; done

real    0m0.817s
user    0m0.500s
sys     0m0.120s
common1 (trunk)$ unset JAVA_HOME
common1 (trunk)$ time for i in {1..10}; do . bin/hadoop-config.sh ; done

real    0m0.806s
user    0m0.550s
sys     0m0.060s
{noformat}

> Add JAVA_HOME detection to hadoop-config
> ----------------------------------------
>
>                 Key: HADOOP-6605
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6605
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Chad Metcalf
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6605.patch, hadoop-6605-1.patch, 
> hadoop-6605-2.patch
>
>
> The commands that source hadoop-config.sh currently bail with an error if 
> JAVA_HOME is not set. Let's detect JAVA_HOME (from a list of locations on 
> various OS types) if JAVA_HOME is not already set by hadoop-env.sh or the 
> environment. This way users don't have to manually configure it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to