[
https://issues.apache.org/jira/browse/HADOOP-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476094#comment-16476094
]
Xiao Chen commented on HADOOP-15154:
------------------------------------
Thanks Zsolt for working on this, looks pretty good to me overall.
Some minors:
- I think naming the {{Object}} parameter to s/subject/stream/g is clearer.
- Should null check the 2 arrays in {{assertCapabilities}}.
> Abstract new method assertCapability for StreamCapabilities testing
> -------------------------------------------------------------------
>
> Key: HADOOP-15154
> URL: https://issues.apache.org/jira/browse/HADOOP-15154
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Reporter: Xiao Chen
> Assignee: Zsolt Venczel
> Priority: Minor
> Attachments: HADOOP-15154.01.patch
>
>
> From Steve's
> [comment|https://issues.apache.org/jira/browse/HADOOP-15149?focusedCommentId=16306806&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16306806]:
> bq. it'd have been cleaner for the asserts to have been one in a
> assertCapability(key, StreamCapabilities subject, bool outcome) and had it
> throw meaningful exceptions on a failure
> We can consider abstract such a method to a test util class and use it for
> all {{StreamCapabilities}} tests as needed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
