[ 
https://issues.apache.org/jira/browse/HADOOP-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478761#comment-16478761
 ] 

Zsolt Venczel commented on HADOOP-15154:
----------------------------------------

Thanks [~xiaochen] for the review, really good points!
I updated the patch by your suggestions.

> Abstract new method assertCapability for StreamCapabilities testing
> -------------------------------------------------------------------
>
>                 Key: HADOOP-15154
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15154
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>            Reporter: Xiao Chen
>            Assignee: Zsolt Venczel
>            Priority: Minor
>         Attachments: HADOOP-15154.01.patch, HADOOP-15154.02.patch
>
>
> From Steve's 
> [comment|https://issues.apache.org/jira/browse/HADOOP-15149?focusedCommentId=16306806&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16306806]:
> bq.  it'd have been cleaner for the asserts to have been one in a 
> assertCapability(key, StreamCapabilities subject, bool outcome) and had it 
> throw meaningful exceptions on a failure
> We can consider abstract such a method to a test util class and use it for 
> all {{StreamCapabilities}} tests as needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to