[ 
https://issues.apache.org/jira/browse/HADOOP-7320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038267#comment-13038267
 ] 

Todd Lipcon commented on HADOOP-7320:
-------------------------------------

- Can you explain the changes with regard to RawLocalFileSystem vs 
LocalFileSystem in TestFsShellReturnCode? I'm not sure I follow what's going on 
here.
- typo "pathson" -> "paths on" for Rename
- maybe rename the outer "Copy" class to "CopyCommands" since it's just a 
container? Also, should it really be extending FsCommand since it is not itself 
a command? (I realize these are left over from HADOOP-7251... can address in a 
separate JIRA if you prefer)

> Refactor FsShell's copy & move commands
> ---------------------------------------
>
>                 Key: HADOOP-7320
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7320
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-7320-2.patch, HADOOP-7320.patch
>
>
> Need to refactor the move and copy commands to conform to the FsCommand class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to