[ 
https://issues.apache.org/jira/browse/HADOOP-7320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038280#comment-13038280
 ] 

Daryn Sharp commented on HADOOP-7320:
-------------------------------------

bq. Can you explain the changes with regard to RawLocalFileSystem vs 
LocalFileSystem in TestFsShellReturnCode? I'm not sure I follow what's going on 
here.

It was confusing for me too.  The property fs.file.impl is supposed to be a 
LocalFileSystem, but the test was defining it as a RawLocalFileSystem.  Calls 
to FileSystem.getLocal() instantiate the fs.file.impl class and then cast it to 
a LocalFileSystem (runtime kaboom).  Using the wrong class accidentally worked 
until this patch.

I'll address the last 2 bullet points on this jira.

> Refactor FsShell's copy & move commands
> ---------------------------------------
>
>                 Key: HADOOP-7320
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7320
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-7320-2.patch, HADOOP-7320.patch
>
>
> Need to refactor the move and copy commands to conform to the FsCommand class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to