[ 
https://issues.apache.org/jira/browse/HADOOP-15637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560065#comment-16560065
 ] 

Chen Liang commented on HADOOP-15637:
-------------------------------------

Thanks [~xkrogen] for reporting and fixing this! The v000 patch LGTM. Just one 
minor comment. This is probably being a bit too picky...it seems 
{{RemoteIterator}} interface does not prevent underlying implementation of 
next() from returning a {{null}}. In which case there will be a NPE on 
{{unfilteredNext.getPath()}}. Can we add this check?

 

> LocalFs#listLocatedStatus does not filter out hidden .crc files
> ---------------------------------------------------------------
>
>                 Key: HADOOP-15637
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15637
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.8.0
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>            Priority: Minor
>         Attachments: HADOOP-15637.000.patch
>
>
> After HADOOP-7165, {{LocalFs#listLocatedStatus}} incorrectly returns the 
> hidden {{.crc}} files used to store checksum information. This is because 
> HADOOP-7165 implemented {{listLocatedStatus}} on {{FilterFs}}, so the default 
> implementation is no longer used, and {{FilterFs}} directly calls the raw FS 
> since {{listLocatedStatus}} is not defined in {{ChecksumFs}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to