[
https://issues.apache.org/jira/browse/HADOOP-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585043#comment-16585043
]
Thomas Marquardt commented on HADOOP-15661:
-------------------------------------------
*ConfigurationKeys.java*:
L83: Please remove the namespace enabled config option. Whether namespace is
enabled or not depends on the storage account setting, and
there is a header returned in the response for Create Filesystem and
Get Filesystem Properties. Having config will cause trouble.
L87: Please remove the config for enabling ACL support. ABFS supports ACLs
when namespace is enabled for the account. The getAclBit function should
return true if an ACL is set; otherwise false.
*FileSystemConfiguration.java*:
L60: Please remove DEFAULT_ENABLE_ACL_BIT
*AbfsAclHelper.java*:
L138: The user is trying to remove the owner, group, or others ACE, which is
an invalid operation. We should throw InvalidAclOperationException, since
this
is not a valid operation on the ACL.
*InvalidAclArgumentException.java*:
Please remove.
*InvalidAclOperationException.java*:
L25: Thrown when there is an attempt to perform an invalid operation on an
ACL.
L31: Please remove. The caller should pass a string message, which should be
passed to the super class.
*AbfsClient.java*:
L398, 430, 460, and 489: throw new UnsupportedException("This operation is
only valid for storage accounts with the hierarchical namespace enabled.")
*AbfsPermissions.java*:
L26: This is not the correct description for the class.
L49: Incorrect description for the method--we should not mention
"adl.feature.support.acl.bit" configuration.
*AbfsConfiguration.java*:
L375: We should remove the namespace enabled config option.
*AzureBlobFileSystem.java*:
L823: I don't think we need this instance method on the file system, as it
has nothing to do with filesystem. Given that it is used twice,
I think we should just call the appropriate method on FsPermissions.
*AzureBlobFileSystemStore.java*:
L73 - don't use ".*" but do import the necessary classes
> ABFS: Add support for ACL
> -------------------------
>
> Key: HADOOP-15661
> URL: https://issues.apache.org/jira/browse/HADOOP-15661
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Da Zhou
> Assignee: Da Zhou
> Priority: Major
> Attachments: HADOOP-15661-HADOOP-15407-001.patch,
> HADOOP-15661-HADOOP-15407-002.patch
>
>
> - Add support for ACL
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
