[
https://issues.apache.org/jira/browse/HADOOP-15676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593538#comment-16593538
]
Zoltan Siegl commented on HADOOP-15676:
---------------------------------------
Hey [~snemeth]!
Did some review on the patch, and I have a few comments might worth considering.
* {{org/apache/hadoop/http/TestSSLHttpServer.java:70}}
{code:java}
public static final String SERVLET_NAME_LONGHEADER = "longheader";
public static final String SERVLET_PATH_LONGHEADER =
"/" + SERVLET_NAME_LONGHEADER;
public static final String SERVLET_NAME_ECHO = "echo";
public static final String SERVLET_PATH_ECHO = "/" + SERVLET_NAME_ECHO;{code}
If there is not specific reason for these to be public, maybe we should
consider making these private.
* {{org/apache/hadoop/http/TestSSLHttpServer.java:248}}
It looks like there has been an additional empty line added in the patch. If
you create a new patch anyways, should we consider removing this?
> Cleanup TestSSLHttpServer
> -------------------------
>
> Key: HADOOP-15676
> URL: https://issues.apache.org/jira/browse/HADOOP-15676
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Affects Versions: 2.6.0
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: HADOOP-15676.001.patch
>
>
> This issue will fix:
> * Several typos in this class
> * Code is not very well readable in some of the places.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
