[
https://issues.apache.org/jira/browse/HADOOP-15676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608286#comment-16608286
]
Xiao Chen commented on HADOOP-15676:
------------------------------------
Thanks [~snemeth] for the improvement here.
Looks like {{testOneEnabledCiphers}} and {{testExclusiveEnabledCiphers}} has
some duplicate codes.
And usually it's not recommended to:
{code}
try {
...
} catch (Exception e) {
fail()
}
{code}
One can expect that the exception can trigger the test failure, and that would
be enough for investigation.
+1 once that's fixed and precommit checkstyle is addressed.
> Cleanup TestSSLHttpServer
> -------------------------
>
> Key: HADOOP-15676
> URL: https://issues.apache.org/jira/browse/HADOOP-15676
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Affects Versions: 2.6.0
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: HADOOP-15676.001.patch, HADOOP-15676.002.patch
>
>
> This issue will fix:
> * Several typos in this class
> * Code is not very well readable in some of the places.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
