[
https://issues.apache.org/jira/browse/HADOOP-15663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596835#comment-16596835
]
Thomas Marquardt commented on HADOOP-15663:
-------------------------------------------
LGTM too. Some comments:
ConfigurationKeys.java
L40: Let's remove FS_AZURE_EMULATOR_ENABLED.
UriUtils.java
L48: extractAccountNameFromHostName would describe this function better
AbfsConfiguration
L176: Let's remove isEmulator() and FS_AZURE_EMULATOR_ENABLED
AzureBlobFileSystemStore.java
L151: Really this is about using test endpoints that use the URL
format http[s]://[ip]:[port]/[account]/[filesystem] instead of
http[s]://[account][domain-suffix]/[filesystem].
AzureTestConstants.java
L147: Now we can name it ACCOUNT_NAME_PROPERTY_NAME and alphabetize
under ACCOUNT_KEY_PROPERTY_NAME.
AbstractAbfsIntegrationTest.java
L65: It is not emulator, but rather the fact that we are using an IP Address
for testing purposes instead of a Host name.
> ABFS: Simplify configuration
> ----------------------------
>
> Key: HADOOP-15663
> URL: https://issues.apache.org/jira/browse/HADOOP-15663
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Reporter: Thomas Marquardt
> Assignee: Da Zhou
> Priority: Major
> Attachments: HADOOP-15663-HADOOP-15407-001.patch,
> HADOOP-15663-HADOOP-15407-002.patch, HADOOP-15663-HADOOP-15407-003.patch
>
>
> Configuration for WASB and ABFS is too complex. The current approach is to
> use four files for test configuration.
> Both WASB and ABFS have basic test configuration which is committed to the
> repo (azure-test.xml and azure-bfs-test.xml). Currently these contain the
> fs.AbstractFileSystem.[scheme].impl configuration, but otherwise are empty
> except for an include reference to a file containing the endpoint
> credentials.
> Both WASB and ABFS have endpoint credential configuration files
> (azure-auth-keys.xml and azure-bfs-auth-keys.xml). These have been added to
> .gitignore to prevent them from accidentally being submitted in a patch,
> which would leak the developers storage account credentials. These files
> contain account names, storage account keys, and service endpoints.
> There is some overlap of the configuration for WASB and ABFS, where they use
> the same property name but use different values.
> 1) Let's reduce the number of test configuration files to one, if possible.
> 2) Let's simplify the account name, key, and endpoint configuration for WASB
> and ABFS if possible, but still support the legacy way of doing it, which is
> very error prone.
> 3) Let's improve error handling, so that typos or misconfiguration are not so
> difficult to troubleshoot.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
