[
https://issues.apache.org/jira/browse/HADOOP-15663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598179#comment-16598179
]
Thomas Marquardt commented on HADOOP-15663:
-------------------------------------------
+1, thanks for addressing the feedback. All tests pass against my US storage
account:
*mvn -T 1C -Dparallel-tests -Dscale -DtestsThreadCount=8 clean verify*
*Tests run: 265, Failures: 0, Errors: 0, Skipped: 11*
*Tests run: 1, Failures: 0, Errors: 0, Skipped: 0*
*Tests run: 863, Failures: 0, Errors: 0, Skipped: 262*
*Tests run: 186, Failures: 0, Errors: 0, Skipped: 10*
I made edits to testing_azure.md to clarify the configuration for running the
tests.
There is a section named *"Testing the Azure ABFS Client"* near the end of the
document,
and readers can copy paste the contents to the file
*src/test/resources/azure-auth-keys.xml*
to get started. The necessary contents are also below:
{noformat}
<?xml version="1.0" encoding="UTF-8"?>
<?xml-stylesheet type="text/xsl" href="configuration.xsl"?>
<configuration xmlns:xi="http://www.w3.org/2001/XInclude";>
<property>
<name>fs.azure.abfs.account.name</name>
<value>{ACCOUNT_NAME}.dfs.core.windows.net</value>
</property>
<property>
<name>fs.azure.account.key.{ACCOUNT_NAME}.dfs.core.windows.net</name>
<value>{ACCOUNT_ACCESS_KEY}</value>
</property>
<property>
<name>fs.azure.wasb.account.name</name>
<value>{ACCOUNT_NAME}.blob.core.windows.net</value>
</property>
<property>
<name>fs.azure.account.key.{ACCOUNT_NAME}.blob.core.windows.net</name>
<value>{ACCOUNT_ACCESS_KEY}</value>
</property>
<property>
<name>fs.contract.test.fs.abfs</name>
<value>abfs://{CONTAINER_NAME}@{ACCOUNT_NAME}.dfs.core.windows.net</value>
<description>A file system URI to be used by the contract
tests.</description>
</property>
<property>
<name>fs.contract.test.fs.wasb</name>
<value>wasb://{CONTAINER_NAME}@{ACCOUNT_NAME}.blob.core.windows.net</value>
<description>A file system URI to be used by the contract
tests.</description>
</property>
</configuration>
{noformat}
> ABFS: Simplify configuration
> ----------------------------
>
> Key: HADOOP-15663
> URL: https://issues.apache.org/jira/browse/HADOOP-15663
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Reporter: Thomas Marquardt
> Assignee: Da Zhou
> Priority: Major
> Attachments: HADOOP-15663-HADOOP-15407-001.patch,
> HADOOP-15663-HADOOP-15407-002.patch, HADOOP-15663-HADOOP-15407-003.patch,
> HADOOP-15663-HADOOP-15407-004.patch, HADOOP-15663-HADOOP-15407-005.patch
>
>
> Configuration for WASB and ABFS is too complex. The current approach is to
> use four files for test configuration.
> Both WASB and ABFS have basic test configuration which is committed to the
> repo (azure-test.xml and azure-bfs-test.xml). Currently these contain the
> fs.AbstractFileSystem.[scheme].impl configuration, but otherwise are empty
> except for an include reference to a file containing the endpoint
> credentials.
> Both WASB and ABFS have endpoint credential configuration files
> (azure-auth-keys.xml and azure-bfs-auth-keys.xml). These have been added to
> .gitignore to prevent them from accidentally being submitted in a patch,
> which would leak the developers storage account credentials. These files
> contain account names, storage account keys, and service endpoints.
> There is some overlap of the configuration for WASB and ABFS, where they use
> the same property name but use different values.
> 1) Let's reduce the number of test configuration files to one, if possible.
> 2) Let's simplify the account name, key, and endpoint configuration for WASB
> and ABFS if possible, but still support the legacy way of doing it, which is
> very error prone.
> 3) Let's improve error handling, so that typos or misconfiguration are not so
> difficult to troubleshoot.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
