[
https://issues.apache.org/jira/browse/HADOOP-15728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606609#comment-16606609
]
Thomas Marquardt commented on HADOOP-15728:
-------------------------------------------
Looks good, some feedback:
*AzureBlobFileSystem.java*:
I recommend calling the implementation on super instead of providing an
implementation when namespace is not enabled. This makes it easier to see that
we are doing the same thing FileSystem does. For example, in the case of
setOwner:
{code:java}
if (!getIsNamespaceEnabeld()) {
super.setOwner(path, owner, group);
return;
}
{code}
*AzureBlobFileSystemStore.java*:
I recommend not modifying setOwner or setPermissions in this file. It is
internal, and you are updating the AzureBlobFileSystem to not call it, so it is
ok for it to continue throwing.
*ITestAzureBlobFileSystemPermission.java* and
*ITestAzureBlobFilesystemAcl.java*:
Just curious, why did we need to move assumeTrue(fs.getIsNamespaceEnabeld())
from the constructor to each test method?
> ABFS: Add backward compatibility to handle Unsupported Operation for storage
> account with no namespace feature
> --------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-15728
> URL: https://issues.apache.org/jira/browse/HADOOP-15728
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Da Zhou
> Assignee: Da Zhou
> Priority: Major
> Attachments: HADOOP-15728-HADOOP-15407-001.patch,
> HADOOP-15728-HADOOP-15407-002.patch
>
>
> For non-namespaceenbaled account, UnsupportedOperationException is thrown
> when setOwner() or setPermission() is called, which cause problems for others.
> They should behave the same as before, so should make them no-op if the
> storage account is not namespace enabled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
