[
https://issues.apache.org/jira/browse/HADOOP-15821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640142#comment-16640142
]
Íñigo Goiri commented on HADOOP-15821:
--------------------------------------
Thanks [[email protected]], replies inline:
{quote}
anything which has an explicit dependency on the yarn-registry artifact isn't
going to build any more. It'll need a stub POM
{quote}
I left the old pom.xml with a dependency to the new hadoop-registry. Is this
enough? Anyway to add a deprecation message?
{quote}the imports are being reordered a lot, and not into the "recommended"
hadoop order either. Can you leave them as close to the originals as possible,
as import reorderings always make cherry picking such a PITA. (I know, it's a
move, but still)
{quote}
I left them as they was.
{quote}moving to loading configuration over YarnConfiguration means that
yarn-site.xml isn't going to get picked up. If that's where any deployment
configures the registry, things will break. I propose using some reflection
game to instantiate a YarnConfiguration instance if it's on the classpath.
{quote}
I created a transient {{RegistryConfiguration}} which adds {{yarn-default.xml}}
and {{yarn-site.xml}}. I think we could add some deprecation message somehow.
{quote}
yes, move the .tla file; probably needs editing & a rebuild of the PDF too. I
should help there (maybe: make editing this a followup & assign to me, unless
you want to learn TLA+).
{quote}
OK, moved right now. Let me know if you want changes for this JIRA; otherwise,
we'll leave it for a follow-up.
{quote}
Why the changes to RegistryDNS?
{quote}
Yetus was complaining a bunch so I went for it.
In [^HADOOP-15821.003.patch] I undid all of them and left it as it was.
I will probably open a followup JIRA for the cleanup of the code but for now
let's keep the scope to just the move.
Thanks [~billie.rinaldi] for the comments, the current status is:
{quote}
Another area we'll have to address is the RegistryDNS daemon command in
hadoop-yarn-project/hadoop-yarn/bin/yarn as well as the exports
YARN_REGISTRYDNS_SECURE_USER, YARN_REGISTRYDNS_SECURE_EXTRA_OPTS in
hadoop-yarn-project/hadoop-yarn/conf/yarn-env.sh. This might be a candidate for
backwards compatibility. Maybe we could keep the yarn command and env vars for
starting the daemon as deprecated, while also introducing a hadoop command? I'm
open to suggestions.
{quote}
I took a pass at it; please check carefully because I'm pretty sure I left
stuff behind.
{quote}
There is also some documentation about how to configure and start RegistryDNS
here:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/yarn-service/ServiceDiscovery.md
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/yarn-service/RegistryDNS.md
{quote}
I updated the references in the files but I think most of the content should
move.
Should I just move both files to hadoop-registry?
> Move Hadoop YARN Registry to Hadoop Registry
> --------------------------------------------
>
> Key: HADOOP-15821
> URL: https://issues.apache.org/jira/browse/HADOOP-15821
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Major
> Attachments: HADOOP-15821.000.patch, HADOOP-15821.001.patch,
> HADOOP-15821.002.patch, HADOOP-15821.003.patch
>
>
> Currently, Hadoop YARN Registry is in YARN. However, this can be used by
> other parts of the project (e.g., HDFS). In addition, it does not have any
> real dependency to YARN.
> We should move it into commons and make it Hadoop Registry.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
