[ 
https://issues.apache.org/jira/browse/HADOOP-7379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047810#comment-13047810
 ] 

Hadoop QA commented on HADOOP-7379:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12482124/hadoop-7379.txt
  against trunk revision 1134218.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 5 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/612//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/612//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/612//console

This message is automatically generated.

> Add ability to include Protobufs in ObjectWritable
> --------------------------------------------------
>
>                 Key: HADOOP-7379
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7379
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io, ipc
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7379.txt
>
>
> Per HDFS-2060, it would make it easier to piecemeal switch to protocol buffer 
> based data structures in the wire protocol if we could intermix the two. The 
> IPC framework currently provides the concept of "engines" for RPC, but that 
> doesn't easily allow mixed types within the same framework for ease of 
> transition.
> I'd like to add the cases to ObjectWritable to be handle subclasses of 
> {{Message}}, the superclass of codegenned protobufs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to