[ 
https://issues.apache.org/jira/browse/HADOOP-7379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047829#comment-13047829
 ] 

Todd Lipcon commented on HADOOP-7379:
-------------------------------------

bq. Todd, what PEDs are you taking? I mean, you're on a roll 

I recently learned how to make pretty good cappuccinos from our machine here at 
the office. No joke, I'm considering a part time job at Blue Bottle. Thanks :)

bq. ProtoUtil.readRawVarint32 is a new implementation vint32 decoding for 
DataInput. It needs test coverage for 1 to 5 bytes.

I actually copy-pasted it from protobufs (compatible license). I can probably 
copy-paste some of their unit tests, too.. I'll look around.

> Add ability to include Protobufs in ObjectWritable
> --------------------------------------------------
>
>                 Key: HADOOP-7379
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7379
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io, ipc
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7379.txt
>
>
> Per HDFS-2060, it would make it easier to piecemeal switch to protocol buffer 
> based data structures in the wire protocol if we could intermix the two. The 
> IPC framework currently provides the concept of "engines" for RPC, but that 
> doesn't easily allow mixed types within the same framework for ease of 
> transition.
> I'd like to add the cases to ObjectWritable to be handle subclasses of 
> {{Message}}, the superclass of codegenned protobufs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to