[
https://issues.apache.org/jira/browse/HADOOP-15987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713431#comment-16713431
]
Sean Mackrory commented on HADOOP-15987:
----------------------------------------
+1, mostly - thanks for making this change. Before I commit though, I'd love to
think of a better term for the other table that's configured then "production".
It's configured the same way you would a production table, but the distinction
is really "tests of MetadataStore implementation" and "tests of DynamoDB table
life-cycle". That only partially overlap.
> ITestDynamoDBMetadataStore should check if test ddb table set properly before
> initializing the test
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-15987
> URL: https://issues.apache.org/jira/browse/HADOOP-15987
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.1.0
> Reporter: Gabor Bota
> Assignee: Gabor Bota
> Priority: Major
> Attachments: HADOOP-15987.001.patch
>
>
> The jira covers the following:
> * We should assert that the table name is configured when
> DynamoDBMetadataStore is used for testing, so the test should fail if it's
> not configured.
> * We should assert that the test table is not the same as the production
> table, as the test table could be modified and destroyed multiple times
> during the test.
> * This behavior should be added to the testing docs.
> [Assume from junit
> doc|http://junit.sourceforge.net/javadoc/org/junit/Assume.html]:
> {noformat}
> A set of methods useful for stating assumptions about the conditions in which
> a test is meaningful.
> A failed assumption does not mean the code is broken, but that the test
> provides no useful information.
> The default JUnit runner treats tests with failing assumptions as ignored.
> {noformat}
> A failed assert will cause test failure instead of just skipping the test.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
