[
https://issues.apache.org/jira/browse/HADOOP-15987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715814#comment-16715814
]
Sean Mackrory commented on HADOOP-15987:
----------------------------------------
As discussed offline today - I don't think there's much to change - I'm just
not a fan of referring to the original config as "production". That is how you
configure it in production, but the distinction is just regular functionality
tests vs. tests that impact the table lifecycle. I just want to be clearer in
the error message and / or docs. But I couldn't think of a better term than
"production". I'll wait until tomorrow to see what you come up with, but it
neither of us has a much more helpful idea, I'm good to just commit as-is.
> ITestDynamoDBMetadataStore should check if test ddb table set properly before
> initializing the test
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-15987
> URL: https://issues.apache.org/jira/browse/HADOOP-15987
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.1.0
> Reporter: Gabor Bota
> Assignee: Gabor Bota
> Priority: Major
> Attachments: HADOOP-15987.001.patch
>
>
> The jira covers the following:
> * We should assert that the table name is configured when
> DynamoDBMetadataStore is used for testing, so the test should fail if it's
> not configured.
> * We should assert that the test table is not the same as the production
> table, as the test table could be modified and destroyed multiple times
> during the test.
> * This behavior should be added to the testing docs.
> [Assume from junit
> doc|http://junit.sourceforge.net/javadoc/org/junit/Assume.html]:
> {noformat}
> A set of methods useful for stating assumptions about the conditions in which
> a test is meaningful.
> A failed assumption does not mean the code is broken, but that the test
> provides no useful information.
> The default JUnit runner treats tests with failing assumptions as ignored.
> {noformat}
> A failed assert will cause test failure instead of just skipping the test.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
