[
https://issues.apache.org/jira/browse/HADOOP-15973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724210#comment-16724210
]
Jason Lowe commented on HADOOP-15973:
-------------------------------------
Thanks for the patch! In addition to the unit test added, I manually verified
that this patch fixes HADOOP-16007.
Nit: We don't need to declare MalformedURLException as being thrown by
handleInclude or handleStartElement since it's a subclass of IOException which
was added to the throws list. And once that's removed we no longer need to
import it.
handleInclude doesn't handle the case where getStreamReader returns null. It
should probably throw in a similar way to how loadResource does when the reader
is null.
> Configuration: Included properties are not cached if resource is a stream
> -------------------------------------------------------------------------
>
> Key: HADOOP-15973
> URL: https://issues.apache.org/jira/browse/HADOOP-15973
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Eric Payne
> Assignee: Eric Payne
> Priority: Critical
> Attachments: HADOOP-15973.001.patch, HADOOP-15973.002.patch
>
>
> If a configuration resource is a bufferedinputstream and the resource has an
> included xml file, the properties from the included file are read and stored
> in the properties of the configuration, but they are not stored in the
> resource cache. So, if a later resource is added to the config and the
> properties are recalculated from the first resource, the included properties
> are lost.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
