[
https://issues.apache.org/jira/browse/HADOOP-15973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725151#comment-16725151
]
Jason Lowe commented on HADOOP-15973:
-------------------------------------
Thanks for updating the patch! I agree the TestSSLFactory failure is
unrelated. I also saw it sporadically fail in HADOOP-15995 with the same
error. I filed HADOOP-16016 to track that error.
Speaking of preserving behaviors, I noticed the old include handling behavior
was to silently ignore cases where it could not build a stream reader if quiet
was true. That's what loadResource does and it used to be leveraged to process
include files. This behavior was not preserved in the new version, but I've
always been confused about the use-case where we don't want to complain/throw
when we can't load something. It seems like that would make things very hard
to debug in practice. I wanted to point this out to confirm the omission of
quiet mode suppression in the new include handling was intentional and see if
anyone can think of a reason why this type of error would want to be suppressed.
> Configuration: Included properties are not cached if resource is a stream
> -------------------------------------------------------------------------
>
> Key: HADOOP-15973
> URL: https://issues.apache.org/jira/browse/HADOOP-15973
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Eric Payne
> Assignee: Eric Payne
> Priority: Critical
> Attachments: HADOOP-15973.001.patch, HADOOP-15973.002.patch,
> HADOOP-15973.003.branch-2.patch, HADOOP-15973.003.branch-3.0.patch,
> HADOOP-15973.003.patch
>
>
> If a configuration resource is a bufferedinputstream and the resource has an
> included xml file, the properties from the included file are read and stored
> in the properties of the configuration, but they are not stored in the
> resource cache. So, if a later resource is added to the config and the
> properties are recalculated from the first resource, the included properties
> are lost.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
