[
https://issues.apache.org/jira/browse/HADOOP-16029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738853#comment-16738853
]
Giovanni Matteo Fumarola commented on HADOOP-16029:
---------------------------------------------------
Thanks [~ayushtkn] .
I think we should start fixing PMD performance and checkstyle warning in the
entire codebase.
Happy to review any patch.
In [^HADOOP-16029-04.patch] GraphiteSink has a wrong indentation compared to
the entire class.
We should fix the PMD warning and later the indentation for the entire class.
> Consecutive Append Should Reuse
> -------------------------------
>
> Key: HADOOP-16029
> URL: https://issues.apache.org/jira/browse/HADOOP-16029
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HADOOP-16029-01.patch, HADOOP-16029-02.patch,
> HADOOP-16029-03.patch, HADOOP-16029-04.patch
>
>
> Consecutive calls to StringBuffer/StringBuilder .append should be chained,
> reusing the target object. This can improve the performance by producing a
> smaller bytecode, reducing overhead and improving inlining.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
