[
https://issues.apache.org/jira/browse/HADOOP-16029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740382#comment-16740382
]
Ayush Saxena commented on HADOOP-16029:
---------------------------------------
[~giovanni.fumarola]
Checkstyle warning is existing one only.Attaching from trunk report.As Decided
will fix separately.
>From trunk build ::
{noformat}
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/GraphiteSink.java:79:
'if' child has incorrect indentation level 16, expected level should be 8.
[Indentation]
{noformat}
Pls Review :)
> Consecutive Append Should Reuse
> -------------------------------
>
> Key: HADOOP-16029
> URL: https://issues.apache.org/jira/browse/HADOOP-16029
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HADOOP-16029-01.patch, HADOOP-16029-02.patch,
> HADOOP-16029-03.patch, HADOOP-16029-04.patch, HADOOP-16029-05.patch
>
>
> Consecutive calls to StringBuffer/StringBuilder .append should be chained,
> reusing the target object. This can improve the performance by producing a
> smaller bytecode, reducing overhead and improving inlining.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
