[ 
https://issues.apache.org/jira/browse/HADOOP-16032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758952#comment-16758952
 ] 

Surendra Singh Lilhore commented on HADOOP-16032:
-------------------------------------------------

Thanks [~RANith] for patch.

Some review comment for test code.
{code:java}
+    CopyListingFileStatus dstStatus = new CopyListingFileStatus(
+        fs.getFileStatus(dest));
+    CopyListingFileStatus srcStatus = new CopyListingFileStatus(
+        fs.getFileStatus(dest));{code}
you are getting source and destination status from same path {{dest}}, pls 
correct this.

I suggest just check the ACL's with your scenario, other things already covered 
by other tests.

> Distcp It should clear sub directory ACL before applying new ACL on it.
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-16032
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16032
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: tools/distcp
>    Affects Versions: 3.1.1
>            Reporter: Ranith Sardar
>            Assignee: Ranith Sardar
>            Priority: Major
>         Attachments: HADOOP-16032.000.patch
>
>
> Distcp preserve can't update the ACL info properly when source dir has access 
>  ACL and dest dir has default ACL. It will only modify the basic ACL part. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to