[
https://issues.apache.org/jira/browse/HADOOP-16032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761074#comment-16761074
]
Steve Loughran commented on HADOOP-16032:
-----------------------------------------
Makes sense, nice low-diff to production code, and a new test.
Can you move all the equals checks in {{testPreserveAclsforDefaultACL()}} to
use assertEquals where possible. with field name. e.g assertEquals("owner",
srcStatus.getOwner(), dstStatus.getOwner());
Other than that, LGTM. Thanks for this
> Distcp It should clear sub directory ACL before applying new ACL on it.
> -----------------------------------------------------------------------
>
> Key: HADOOP-16032
> URL: https://issues.apache.org/jira/browse/HADOOP-16032
> Project: Hadoop Common
> Issue Type: Bug
> Components: tools/distcp
> Affects Versions: 3.1.1
> Reporter: Ranith Sardar
> Assignee: Ranith Sardar
> Priority: Major
> Attachments: HADOOP-16032.000.patch, HADOOP-16032.001.patch,
> HADOOP-16032.002.patch
>
>
> Distcp preserve can't update the ACL info properly when source dir has access
> ACL and dest dir has default ACL. It will only modify the basic ACL part.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
