[
https://issues.apache.org/jira/browse/HADOOP-15942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788887#comment-16788887
]
Ayush Saxena commented on HADOOP-15942:
---------------------------------------
[~OneisAll] the checkstyle warning isn't for the line length.
This time it is for the improper indentations,
[[email protected]] already had put the warnings up in his comment you can
just follow them up.
The first one is just you should have 6 blank spaces before starting the
statement.
The other three are just you need to add a space after each '*,*' in
{noformat}
,attName,oname,e
{noformat}
And after this if it lands up being more than 80. You can split the statement
in 2 lines. Hope that helps.
> Change the logging level form DEBUG to ERROR for RuntimeErrorException in
> JMXJsonServlet
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-15942
> URL: https://issues.apache.org/jira/browse/HADOOP-15942
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Affects Versions: 3.1.0
> Reporter: Anuhan Torgonshar
> Priority: Major
> Labels: easyfix
> Attachments: HADOOP-15942.trunk.patch
>
>
> In *JMXJsonServlet.java* file, when invokes *MBeanServer.getAttribute()*
> method, many catch clauses followed, and each of them contains a log
> statement, most of them set the logging level to *ERROR*. However, when
> catches *RuntimeErrorException* in line 348 (r1839798), the logging level of
> log statement in this catch clause is *DEBUG*, the annotation indicates that
> an unexpected failure occured in getAttribute method before, so I think the
> logging level shuold be *ERROR* level too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
