[ 
https://issues.apache.org/jira/browse/HADOOP-15942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793737#comment-16793737
 ] 

Ayush Saxena commented on HADOOP-15942:
---------------------------------------

Thanx [~OneisAll] for the patch. The change seems fair enough to me.

Just a minor thought. Now one line is on logger and couple of others still 
follow the old regime. We may even consider upgrading them too.

Well If [[email protected]] is happy enough. He can help you get this in. :)

> Change the logging level form DEBUG to ERROR for RuntimeErrorException in 
> JMXJsonServlet
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-15942
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15942
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>    Affects Versions: 3.1.0
>            Reporter: Anuhan Torgonshar
>            Priority: Major
>              Labels: easyfix
>         Attachments: HADOOP-15942.trunk.patch
>
>
> In *JMXJsonServlet.java* file, when invokes *MBeanServer.getAttribute()* 
> method, many catch clauses followed, and each of them contains a log 
> statement, most of them set the logging level to *ERROR*. However, when 
> catches *RuntimeErrorException* in line 348 (r1839798), the logging level of 
> log statement in this catch clause is *DEBUG*, the annotation indicates that 
> an unexpected failure occured in getAttribute method before, so I think the 
> logging level shuold be *ERROR* level too. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to