[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793153#comment-16793153
]
Siyao Meng commented on HADOOP-13656:
-------------------------------------
Thanks for the patch. Some suggestions:
1. Line 238: I believe you could use
{code:java}
CommandFormat cf = new CommandFormat(0, 1, "immediate", "fs");
{code}
instead of cf.addOptionWithValue() to keep consistent coding style.
2. Line 226: "[-immediate] [-fs <path> ]"; <- extra whitespace between > and
last ]. keep the style consistent with your doc.
3. Line 285: remove extra trailing whitespace.
> fs -expunge to take a filesystem
> --------------------------------
>
> Key: HADOOP-13656
> URL: https://issues.apache.org/jira/browse/HADOOP-13656
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 2.7.3
> Reporter: Steve Loughran
> Assignee: Shweta
> Priority: Minor
> Attachments: HADOOP-13656.001.patch, HADOOP-13656.002.patch,
> HADOOP-13656.003.patch
>
>
> you can't pass in a filesystem or object store to {{fs -expunge}; you have to
> change the default fs
> {code}
> hadoop fs -expunge -D fs.defaultFS=s3a://bucket/
> {code}
> If the command took an optional filesystem argument, it'd be better at
> cleaning up object stores. Given that even deleted object store data runs up
> bills, this could be appreciated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
