[ 
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793893#comment-16793893
 ] 

Shweta commented on HADOOP-13656:
---------------------------------

Thanks [~smeng] for the review.
1. The new command "-fs" takes a filesystem argument and hence the use of
{code}cf.addOptionWithValue() {code} . Using this helps in better parsing the 
arguments in CommandFormat. I have used Count command as a reference for adding 
the new option in Delete.

2. Good catch about the white space. Missed that one.

3. I did not notice the whitespace at L:285. Did you mean line break after 
L:286?

Posted patch v004.Please review.

> fs -expunge to take a filesystem
> --------------------------------
>
>                 Key: HADOOP-13656
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13656
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: 2.7.3
>            Reporter: Steve Loughran
>            Assignee: Shweta
>            Priority: Minor
>         Attachments: HADOOP-13656.001.patch, HADOOP-13656.002.patch, 
> HADOOP-13656.003.patch
>
>
> you can't pass in a filesystem or object store to {{fs -expunge}; you have to 
> change the default fs
> {code}
> hadoop fs -expunge -D fs.defaultFS=s3a://bucket/
> {code}
> If the command took an optional filesystem argument, it'd be better at 
> cleaning up object stores. Given that even deleted object store data runs up 
> bills, this could be appreciated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to