hanishakoneru commented on a change in pull request #626: HDDS-1262. In OM HA
OpenKey and initiateMultipartUpload call Should happen only leader OM.
URL: https://github.com/apache/hadoop/pull/626#discussion_r268887028
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -2474,6 +2524,28 @@ public String getOzoneBucketMapping(String s3BucketName)
}
}
+
+ @Override
+ public OmMultipartInfo applyInitiateMultipartUpload(OmKeyArgs keyArgs,
+ String multipartUploadID) throws IOException {
+ OmMultipartInfo multipartInfo;
+ metrics.incNumInitiateMultipartUploads();
+ try {
+ multipartInfo = keyManager.applyInitiateMultipartUpload(keyArgs,
+ multipartUploadID);
+ AUDIT.logWriteSuccess(buildAuditMessageForSuccess(
+ OMAction.INITIATE_MULTIPART_UPLOAD, (keyArgs == null) ? null :
+ keyArgs.toAuditMap()));
+ } catch (IOException ex) {
+ AUDIT.logWriteFailure(buildAuditMessageForFailure(
+ OMAction.INITIATE_MULTIPART_UPLOAD,
+ (keyArgs == null) ? null : keyArgs.toAuditMap(), ex));
+ metrics.incNumInitiateMultipartUploadFails();
Review comment:
The metrics and Audit log would be updated twice with the same OMAction
(INITIATE_MULTIPART_UPLOAD). Can we create new OMAction for this method also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
