hanishakoneru commented on a change in pull request #626: HDDS-1262. In OM HA
OpenKey and initiateMultipartUpload call Should happen only leader OM.
URL: https://github.com/apache/hadoop/pull/626#discussion_r268885709
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java
##########
@@ -181,6 +297,17 @@ private TransactionContext handleAllocateBlock(
}
+ /**
+ * Construct IOException message for failed requests in StartTransaction.
+ * @param omResponse
+ * @return
+ */
+ private IOException constructExceptionForFailedRequest(
+ OMResponse omResponse) {
+ return new IOException(omResponse.getMessage() + " " +
+ STATUS_CODE + omResponse.getStatus());
+ }
Review comment:
Instead of creating an IOException and then parsing the status code back at
the client, can we use OMException instead? We can add the Status parameter to
OMException.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
