noslowerdna commented on a change in pull request #646: HADOOP-16085: use
object version or etags to protect against inconsistent read after
replace/overwrite
URL: https://github.com/apache/hadoop/pull/646#discussion_r269727362
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileStatus.java
##########
@@ -67,31 +89,64 @@ public S3AFileStatus(Tristate isemptydir,
* @param path path
* @param blockSize block size
* @param owner owner
+ * @param eTag eTag of the S3 object if available, else null
+ * @param versionId versionId of the S3 object if available, else null
*/
public S3AFileStatus(long length, long modification_time, Path path,
- long blockSize, String owner) {
- super(length, false, 1, blockSize, modification_time, path);
+ long blockSize, String owner, String eTag, String versionId) {
+ super(length, false, 1, blockSize, modification_time,
+ path);
isEmptyDirectory = Tristate.FALSE;
+ this.eTag = eTag;
+ this.versionId = versionId;
setOwner(owner);
setGroup(owner);
}
+ /**
+ * A simple file.
+ * @param length file length
+ * @param modification_time mod time
+ * @param access_time access time
+ * @param path path
+ * @param blockSize block size
+ * @param owner owner
+ * @param group group
+ * @param permission persmission
Review comment:
typo, persmission
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
