noslowerdna commented on a change in pull request #646: HADOOP-16085: use
object version or etags to protect against inconsistent read after
replace/overwrite
URL: https://github.com/apache/hadoop/pull/646#discussion_r269730870
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -2859,12 +2893,15 @@ public String getCanonicalServiceName() {
* @param srcKey source object path
* @param dstKey destination object path
* @param size object size
+ * @param srcAttributes S3 attributes of the source object
+ * @param readContext the read context
* @throws AmazonClientException on failures inside the AWS SDK
* @throws InterruptedIOException the operation was interrupted
* @throws IOException Other IO problems
*/
@Retries.RetryMixed
- private void copyFile(String srcKey, String dstKey, long size)
+ private CopyResult copyFile(String srcKey, String dstKey, long size,
Review comment:
add @return javadoc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
