ben-roling commented on a change in pull request #666: HADOOP-16221 add option
to fail operation on metadata write failure
URL: https://github.com/apache/hadoop/pull/666#discussion_r270539161
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/WriteOperationHelper.java
##########
@@ -236,7 +236,8 @@ public String initiateMultiPartUpload(String destKey)
throws IOException {
* @return the result of the operation.
* @throws IOException on problems.
*/
- @Retries.RetryTranslated
+ @Retries.RetryTranslated("For complete MPU; post-complete actions are "
Review comment:
I think I have this wrong. Now my impression is I shouldn't have changed
this annotation. This entire operation is effectively RetryTranslated. This
method itself retries and translates exceptions on complete-MPU and the
finishedWrite() method retries and translates exceptions internal to itself
(via the retrying and translating occurring in DynamoDBMetadataStore). Is that
how you would think of it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
