ben-roling commented on a change in pull request #666: HADOOP-16221 add option
to fail operation on metadata write failure
URL: https://github.com/apache/hadoop/pull/666#discussion_r270555610
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Retries.java
##########
@@ -26,11 +26,23 @@
import org.apache.hadoop.classification.InterfaceStability;
/**
- * Declaration of retry policy for documentation only.
- * This is purely for visibility in source and is currently package-scoped.
- * Compare with {@link org.apache.hadoop.io.retry.AtMostOnce}
- * and {@link org.apache.hadoop.io.retry.Idempotent}; these are real
- * markers used by Hadoop RPC.
+ * <p>
+ * Annotations to inform the caller of an annotated method whether
Review comment:
I tried to improve the documentation of this class here. I'm curious if I
have captured the real intended meaning/purpose of these annotations? If so,
hopefully it will help the next developer understand the goal better than I did
initially.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]