mackrorysd commented on a change in pull request #675: HADOOP-16085: use object
version or etags to protect against inconsistent read after replace/overwrite
URL: https://github.com/apache/hadoop/pull/675#discussion_r276304189
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/TestDirListingMetadata.java
##########
@@ -130,7 +133,8 @@ public void testGet() {
PathMetadata pathMeta2 = new PathMetadata(
new S3AFileStatus(true, new Path(path, "dir2"), TEST_OWNER));
PathMetadata pathMeta3 = new PathMetadata(
- new S3AFileStatus(123, 456, new Path(path, "file1"), 8192,
TEST_OWNER));
+ new S3AFileStatus(123, 456, new Path(path, "file1"), 8192, TEST_OWNER,
+ "abc", "def"));
Review comment:
Why not use TEST_ETAG and TEST_VERSIONID here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
