mackrorysd commented on a change in pull request #675: HADOOP-16085: use object
version or etags to protect against inconsistent read after replace/overwrite
URL: https://github.com/apache/hadoop/pull/675#discussion_r276304617
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/TestLocalMetadataStore.java
##########
@@ -169,7 +171,9 @@ private static void populateMap(Cache<Path,
LocalMetadataEntry> cache,
private static void populateEntry(Cache<Path, LocalMetadataEntry> cache,
Path path) {
FileStatus fileStatus = new FileStatus(0, true, 0, 0, 0, path);
- cache.put(path, new LocalMetadataEntry(new PathMetadata(fileStatus)));
+ S3AFileStatus s3aStatus = S3AFileStatus.fromFileStatus(
Review comment:
There's *a lot* of calls like this. Cleaner to just create S3AFileStatus
directly in most of these cases, yeah?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
