[
https://issues.apache.org/jira/browse/HADOOP-12693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820775#comment-16820775
]
Akira Ajisaka commented on HADOOP-12693:
----------------------------------------
bq. I would suggest we introduce AssertJ for the new tests avoiding such
mistakes.
Good news: AssertJ has been introduced in Apache Hadoop. YARN-9470 fixed the
misusages by replacing the JUnit API with AssertJ.
> Many misusages of assertEquals(expected, actual)
> ------------------------------------------------
>
> Key: HADOOP-12693
> URL: https://issues.apache.org/jira/browse/HADOOP-12693
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Akihiro Suda
> Priority: Trivial
> Attachments: just-rough-approx.txt
>
>
> The first arg of {{org.JUnit.Assert.assertEquals()}} should be an
> {{expected}} value, and the second one should be an {{actual}} value.
> {code}
> void assertEquals(T expected, T actual);
> {code}
> http://junit.org/apidocs/org/junit/Assert.html#assertEquals(java.lang.Object,
> java.lang.Object)
> However, there are so many violations in Hadoop, which can make a misleading
> message like this:
> {code}
> AssertionError: expected:<actual> but was:<expected>
> {code}.
> Please refer to {{just-rough-approx.txt}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
