[ 
https://issues.apache.org/jira/browse/HADOOP-12693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821137#comment-16821137
 ] 

Adam Antal commented on HADOOP-12693:
-------------------------------------

Filed MAPREDUCE-7197 for creating a follow-up for the MR project.

> Many misusages of assertEquals(expected, actual)
> ------------------------------------------------
>
>                 Key: HADOOP-12693
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12693
>             Project: Hadoop Common
>          Issue Type: Test
>            Reporter: Akihiro Suda
>            Priority: Trivial
>         Attachments: just-rough-approx.txt
>
>
> The first arg of {{org.JUnit.Assert.assertEquals()}} should be an 
> {{expected}} value, and the second one should be an {{actual}} value.
> {code}
> void assertEquals(T expected, T actual);
> {code}
> http://junit.org/apidocs/org/junit/Assert.html#assertEquals(java.lang.Object, 
> java.lang.Object)
> However, there are so many violations in Hadoop, which can make a misleading 
> message like this:
> {code}
> AssertionError: expected:<actual> but was:<expected>
> {code}.
> Please refer to {{just-rough-approx.txt}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to