swagle commented on a change in pull request #846: HDDS-1555. Disable install
snapshot for ContainerStateMachine.
URL: https://github.com/apache/hadoop/pull/846#discussion_r287022436
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
##########
@@ -146,7 +146,7 @@
public static final String DFS_RATIS_SNAPSHOT_THRESHOLD_KEY =
"dfs.ratis.snapshot.threshold";
- public static final long DFS_RATIS_SNAPSHOT_THRESHOLD_DEFAULT = 10000;
+ public static final long DFS_RATIS_SNAPSHOT_THRESHOLD_DEFAULT = 100000;
Review comment:
Hi @jiwq, thanks for the review. While doing performance testing with 160
client threads writing small files to a 50 node cluster continuously, we
observed the snapshot taken a bit too often. Hence, this change to update the
default limit with my change being in a very related area.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
