xiaoyuyao commented on a change in pull request #847: HDDS-1539. Implement
addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar.
URL: https://github.com/apache/hadoop/pull/847#discussion_r287902348
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/protocolPB/OMPBHelper.java
##########
@@ -122,10 +121,9 @@ public static OzoneAcl convertOzoneAcl(OzoneAclInfo
aclInfo) {
throw new IllegalArgumentException("ACL type is not recognized");
}
- List<IAccessAuthorizer.ACLType> aclRights = new ArrayList<>();
- for (OzoneAclRights acl : aclInfo.getRightsList()) {
- aclRights.add(ACLType.valueOf(acl.name()));
- }
+ BitSet aclRights = new BitSet(aclInfo.getRightsList().size());
Review comment:
We should not use this to set the BitSet size
*aclInfo.getRightsList().size()*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
