xiaoyuyao commented on a change in pull request #847: HDDS-1539. Implement
addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar.
URL: https://github.com/apache/hadoop/pull/847#discussion_r288154315
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java
##########
@@ -528,12 +538,11 @@ public void deleteVolume(String volume) throws
IOException {
ListVolumeResponse resp =
handleError(submitRequest(omRequest)).getListVolumeResponse();
-
-
-
- return resp.getVolumeInfoList().stream()
- .map(item -> OmVolumeArgs.getFromProtobuf(item))
- .collect(Collectors.toList());
+ List<OmVolumeArgs> list = new ArrayList<>(resp.getVolumeInfoList().size());
Review comment:
The change is the same as the original lambada based implementation. Any
reason for that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
