anuengineer commented on a change in pull request #868: HDDS-1568 : Add RocksDB
metrics to OM.
URL: https://github.com/apache/hadoop/pull/868#discussion_r288727594
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/RocksDBStoreMBean.java
##########
@@ -41,13 +49,21 @@
/**
* Adapter JMX bean to publish all the Rocksdb metrics.
*/
-public class RocksDBStoreMBean implements DynamicMBean {
+public class RocksDBStoreMBean implements DynamicMBean, MetricsSource {
Review comment:
@elek Will this automatically show up in the Promotheus ? or do we need to
any extra plumbing ? See the comment in the JIRA where @jnp talks about
Container metrics on Datanodes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
