anuengineer commented on a change in pull request #868: HDDS-1568 : Add RocksDB
metrics to OM.
URL: https://github.com/apache/hadoop/pull/868#discussion_r288728813
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/DBStoreBuilder.java
##########
@@ -187,7 +196,13 @@ private DBOptions getDbProfile() {
if (option == null) {
LOG.info("Using default options. {}", dbProfile.toString());
- return dbProfile.getDBOptions();
+ option = dbProfile.getDBOptions();
+ }
+
+ if (!rocksDbStat.equals(OZONE_METADATA_STORE_ROCKSDB_STATISTICS_OFF)) {
Review comment:
There is some history here. During our first release we found that RocksDB
is also shipped by YARN. That version of RocksDB is very old, hence this call
would fail in mysterious ways. @arp7 went and fixed that issue and made sure
that we don't enable this by default. I am fine with enabling this, if we don't
run into that old issue again. @elek, @arp7 any comments ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
