bgaborg commented on a change in pull request #951: HADOOP-15183. S3Guard store
becomes inconsistent after partial failure of rename
URL: https://github.com/apache/hadoop/pull/951#discussion_r292963979
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -2359,6 +2708,37 @@ public UserGroupInformation getOwner() {
return owner;
}
+ /**
+ * Build an immutable store context.
+ * If called while the FS is being initialized,
+ * some of the context will be incomplete.
+ * new store context instances should be created as appropriate.
+ * @return the store context of this FS.
+ */
+ @InterfaceAudience.Private
+ public StoreContext createStoreContext() {
Review comment:
This is a lot of parameters for a constructor. I think it would worth to use
builder pattern for readability and sustainability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
