bgaborg commented on a change in pull request #951: HADOOP-15183. S3Guard store
becomes inconsistent after partial failure of rename
URL: https://github.com/apache/hadoop/pull/951#discussion_r295465643
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/LocalMetadataStore.java
##########
@@ -192,15 +202,19 @@ public synchronized DirListingMetadata listChildren(Path
p) throws
}
@Override
- public void move(Collection<Path> pathsToDelete,
- Collection<PathMetadata> pathsToCreate,
- ITtlTimeProvider ttlTimeProvider) throws IOException {
+ public void move(
+ @Nullable Collection<Path> pathsToDelete,
+ @Nullable Collection<PathMetadata> pathsToCreate,
+ ITtlTimeProvider ttlTimeProvider,
Review comment:
Yes we did. I started a discussion about this if we want to pass it in the
metastore init instead of every method which will use it. We ended up passing
it to every method instead of the init method. We need to fix that. If that is
not fixed in this pr I will fix it tomorrow under a new issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
