xiaoyuyao commented on a change in pull request #931: HDDS-1586. Allow Ozone
RPC client to read with topology awareness.
URL: https://github.com/apache/hadoop/pull/931#discussion_r293460005
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestKeyManagerImpl.java
##########
@@ -596,6 +620,81 @@ private OmKeyArgs createKeyArgs(String toKeyName) throws
IOException {
return createBuilder().setKeyName(toKeyName).build();
}
+ @Test
+ public void testLookupKeyWithLocation() throws IOException {
+ String keyName = RandomStringUtils.randomAlphabetic(5);
+ OmKeyArgs keyArgs = createBuilder()
+ .setKeyName(keyName)
+ .build();
+
+ // lookup for a non-existent key
+ try {
+ keyManager.lookupKey(keyArgs, null);
+ Assert.fail("Lookup key should fail for non existent key");
+ } catch (OMException ex) {
+ if (ex.getResult() != OMException.ResultCodes.KEY_NOT_FOUND) {
+ throw ex;
+ }
+ }
+
+ // create a key
+ OpenKeySession keySession = keyManager.createFile(keyArgs, false, false);
+ // randomly select 3 datanodes
+ List<DatanodeDetails> nodeList = new ArrayList<>();
+ nodeList.add((DatanodeDetails)scm.getClusterMap().getNode(
+ 0, null, null, null, null, 0));
+ nodeList.add((DatanodeDetails)scm.getClusterMap().getNode(
+ 1, null, null, null, null, 0));
+ nodeList.add((DatanodeDetails)scm.getClusterMap().getNode(
+ 2, null, null, null, null, 0));
+ Assume.assumeTrue(nodeList.get(0) != nodeList.get(1));
Review comment:
should we use .equals() here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
