xiaoyuyao commented on a change in pull request #931: HDDS-1586. Allow Ozone
RPC client to read with topology awareness.
URL: https://github.com/apache/hadoop/pull/931#discussion_r293471766
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientManager.java
##########
@@ -150,11 +201,16 @@ public void releaseClient(XceiverClientSpi client,
boolean invalidateClient) {
}
}
- private XceiverClientSpi getClient(Pipeline pipeline)
+ private XceiverClientSpi getClient(Pipeline pipeline, boolean forRead)
throws IOException {
HddsProtos.ReplicationType type = pipeline.getType();
try {
+ // create different client for read different pipeline node based on
+ // network topology
String key = pipeline.getId().getId().toString() + type;
Review comment:
Can we wrap this logic in a help function like getPipelineKey()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
