mackrorysd commented on a change in pull request #951: HADOOP-15183. S3Guard
store becomes inconsistent after partial failure of rename
URL: https://github.com/apache/hadoop/pull/951#discussion_r295413962
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/LocalMetadataStore.java
##########
@@ -192,15 +202,19 @@ public synchronized DirListingMetadata listChildren(Path
p) throws
}
@Override
- public void move(Collection<Path> pathsToDelete,
- Collection<PathMetadata> pathsToCreate,
- ITtlTimeProvider ttlTimeProvider) throws IOException {
+ public void move(
+ @Nullable Collection<Path> pathsToDelete,
+ @Nullable Collection<PathMetadata> pathsToCreate,
+ ITtlTimeProvider ttlTimeProvider,
Review comment:
I still don't immediately seeing ttlTimeProvider being used everywhere it's
passed. Did we get to the bottom of that? Now's the time to remove it, maybe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
