mackrorysd commented on a change in pull request #951: HADOOP-15183. S3Guard
store becomes inconsistent after partial failure of rename
URL: https://github.com/apache/hadoop/pull/951#discussion_r295412576
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -418,9 +434,11 @@ private void initThreadPools(Configuration conf) {
unboundedThreadPool = new ThreadPoolExecutor(
maxThreads, Integer.MAX_VALUE,
Review comment:
This is where I had suggested we drop the first argument to 0 (for
boundedThreadPool too) as that's core threads, not max threads. Otherwise we
actually lock ourselves at the maximum and grow from there. Only if you rebuild
and retest anyway - otherwise I'll submit a patch once this is in to avoid
further conflicts...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
