[
https://issues.apache.org/jira/browse/HADOOP-16395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874661#comment-16874661
]
yanghuafeng commented on HADOOP-16395:
--------------------------------------
Thanks for your comments, [~xkrogen]
{quote}Why are we defining a new CloseableQueue interface? Can't we just say
that FairCallQueue implements Closeable?{quote}
In general, the interface Closeable is used to release resources about IO
objects, for example XXOutputStream. Is it proper for FCQ to implements this
interface?
{quote}You've added a close() method to FairCallQueue, but it is not called
anywhere. I think in swapQueues you need to check if the queue is instanceof
Closeable, and if so, close it.{quote}
Whoops! I have missed something. And I have committed new patch
HADOOP-16395.002.patch
I have read HADOOP-10282. Although we can use multiple FCQ with different
namespace, we can safely unregister the fcq belonging to specific namespace.
Could you give some advice? [~arp]
> when CallQueueManager swap queues, we should remove metrics about FCQ
> ---------------------------------------------------------------------
>
> Key: HADOOP-16395
> URL: https://issues.apache.org/jira/browse/HADOOP-16395
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common, ipc
> Affects Versions: 3.2.0
> Reporter: yanghuafeng
> Priority: Minor
> Attachments: HADOOP-16395.001.patch, HADOOP-16395.002.patch
>
>
> when we use "dfsadmin -refreshCallQueue" between FCQ and LBQ, we find that
> the metrics about FCQ still display by the JMX. Normally the metrics should
> disappear like what DecayRpcScheduler did.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
